Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter to specify id column for heatmap #48

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Add parameter to specify id column for heatmap #48

merged 2 commits into from
Aug 23, 2023

Conversation

christopher-mohr
Copy link
Collaborator

@christopher-mohr christopher-mohr commented Aug 21, 2023 •
edited
Loading

This adds a parameter to specify the id column that will be used for the heatmap rows. This can be used in cases where the sample_id is not unique or users would like to specify additional custom names.

Fixes #39

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/nanostring branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Aug 21, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 2f90252

+| ✅ 158 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-21 09:12:27

grst
grst approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just if this R script get's even a little more complicated, I'd consider a real argument parser ;)

@christopher-mohr
Copy link
Collaborator Author

LGTM!

Just if this R script get's even a little more complicated, I'd consider a real argument parser ;)

Thank you! Totally agree 👍

@christopher-mohr christopher-mohr merged commit 390fe60 into nf-core:dev Aug 23, 2023
@christopher-mohr christopher-mohr deleted the add_params branch August 23, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grst grst grst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christopher-mohr @grst